support Mirrored mode networking for wsl2 #879
Conversation
| def controller_protocol(): | ||
| protocol = 'tcp' if (has_shared_folder() or is_wsl()) else 'ipc' | ||
| return protocol | ||
|
|
||
|
|
||
| def controller_ip_address(): | ||
| ip_address = get_host_ip() if has_shared_folder() else get_wsl_ip_address() | ||
| ip_address = get_router_ip() if has_shared_folder() else get_wsl_ip_address() |
There was a problem hiding this comment.
| ip_address = get_router_ip() if has_shared_folder() else get_wsl_ip_address() | |
| ip_address = get_router_ip() if has_shared_folder() else get_wsl_host_ip() |
There was a problem hiding this comment.
I'm not sure the purpose of the function controller_ip_address. In mirrored mode, the return value of get_wsl_host_ip is fixed as 127.0.0.42
| return ip_address | ||
|
|
||
|
|
||
| def controller_url_prefix(port='1234'): | ||
| if has_shared_folder() or is_wsl(): | ||
| return 'tcp://' + (get_host_ip() if has_shared_folder() else get_wsl_ip_address()) + ':' + port + '/' | ||
| return 'tcp://' + (get_router_ip() if has_shared_folder() else get_wsl_ip_address()) + ':' + port + '/' |
There was a problem hiding this comment.
| return 'tcp://' + (get_router_ip() if has_shared_folder() else get_wsl_ip_address()) + ':' + port + '/' | |
| return 'tcp://' + (get_router_ip() if has_shared_folder() else get_wsl_host_ip()) + ':' + port + '/' |
There was a problem hiding this comment.
but get_wsl_ip_address shoud be used here
There was a problem hiding this comment.
You renamed this get_wsl_ip_address function to get_wsl_host_ip.
There was a problem hiding this comment.
if the file /etc/resolv.conf exist, the function get_wsl_host_ip never return 127.0.0.1 whatever the mode.
But get_wsl_ip_address can return get_wsl_host_ip or localhost
There was a problem hiding this comment.
What I mean here is that in this PR, get_wsl_ip_address doesn't exist any more. You renamed it to get_wsl_host_ip. So, the above line will fail due to an attempt to call an unknown function.
Co-authored-by: Olivier Michel <[email protected]>
Description
Mirrored mode networking is a new network mode of wsl2. In this mode, we can use localhost accessing Windows networking apps from Linux.
When the following is written in the
.wslconfigfile, the wsl2 is switched to Mirrored modeRelated Issues
maybe #759
Affected Packages
Tasks
Add the list of tasks of this PR.
Additional context